From 5ca038d888922e93bf45c7bd37f3c6dce849dcff Mon Sep 17 00:00:00 2001 From: 疯狂的狮子li <15040126243@163.com> Date: 星期五, 24 十二月 2021 11:36:02 +0800 Subject: [PATCH] update 调整监控依赖 从 common 迁移到 framework --- ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysRoleServiceImpl.java | 126 ++++++++++++++++++++++++----------------- 1 files changed, 73 insertions(+), 53 deletions(-) diff --git a/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysRoleServiceImpl.java b/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysRoleServiceImpl.java index e04fdcf..514afb1 100644 --- a/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysRoleServiceImpl.java +++ b/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysRoleServiceImpl.java @@ -1,14 +1,16 @@ package com.ruoyi.system.service.impl; -import cn.hutool.core.lang.Validator; import com.baomidou.mybatisplus.core.conditions.query.LambdaQueryWrapper; -import com.ruoyi.common.annotation.DataScope; +import com.baomidou.mybatisplus.extension.plugins.pagination.Page; import com.ruoyi.common.constant.UserConstants; +import com.ruoyi.common.core.domain.PageQuery; import com.ruoyi.common.core.domain.entity.SysRole; +import com.ruoyi.common.core.domain.entity.SysUser; import com.ruoyi.common.core.mybatisplus.core.ServicePlusImpl; import com.ruoyi.common.core.page.TableDataInfo; -import com.ruoyi.common.exception.CustomException; -import com.ruoyi.common.utils.PageUtils; +import com.ruoyi.common.exception.ServiceException; +import com.ruoyi.common.utils.SecurityUtils; +import com.ruoyi.common.utils.StringUtils; import com.ruoyi.common.utils.spring.SpringUtils; import com.ruoyi.system.domain.SysRoleDept; import com.ruoyi.system.domain.SysRoleMenu; @@ -27,10 +29,10 @@ /** * 瑙掕壊 涓氬姟灞傚鐞� * - * @author ruoyi + * @author Lion Li */ @Service -public class SysRoleServiceImpl extends ServicePlusImpl<SysRoleMapper, SysRole> implements ISysRoleService { +public class SysRoleServiceImpl extends ServicePlusImpl<SysRoleMapper, SysRole, SysRole> implements ISysRoleService { @Autowired private SysRoleMenuMapper roleMenuMapper; @@ -42,9 +44,9 @@ private SysRoleDeptMapper roleDeptMapper; @Override - @DataScope(deptAlias = "d") - public TableDataInfo<SysRole> selectPageRoleList(SysRole role) { - return PageUtils.buildDataInfo(baseMapper.selectPageRoleList(PageUtils.buildPage(), role)); + public TableDataInfo<SysRole> selectPageRoleList(SysRole role, PageQuery pageQuery) { + Page<SysRole> page = baseMapper.selectPageRoleList(pageQuery.build(), role); + return TableDataInfo.build(page); } /** @@ -54,7 +56,6 @@ * @return 瑙掕壊鏁版嵁闆嗗悎淇℃伅 */ @Override - @DataScope(deptAlias = "d") public List<SysRole> selectRoleList(SysRole role) { return baseMapper.selectRoleList(role); } @@ -66,16 +67,12 @@ * @return 瑙掕壊鍒楄〃 */ @Override - public List<SysRole> selectRolesByUserId(Long userId) - { - List<SysRole> userRoles = roleMapper.selectRolePermissionByUserId(userId); + public List<SysRole> selectRolesByUserId(Long userId) { + List<SysRole> userRoles = baseMapper.selectRolePermissionByUserId(userId); List<SysRole> roles = selectRoleAll(); - for (SysRole role : roles) - { - for (SysRole userRole : userRoles) - { - if (role.getRoleId().longValue() == userRole.getRoleId().longValue()) - { + for (SysRole role : roles) { + for (SysRole userRole : userRoles) { + if (role.getRoleId().longValue() == userRole.getRoleId().longValue()) { role.setFlag(true); break; } @@ -95,7 +92,7 @@ List<SysRole> perms = baseMapper.selectRolePermissionByUserId(userId); Set<String> permsSet = new HashSet<>(); for (SysRole perm : perms) { - if (Validator.isNotNull(perm)) { + if (StringUtils.isNotNull(perm)) { permsSet.addAll(Arrays.asList(perm.getRoleKey().trim().split(","))); } } @@ -119,7 +116,7 @@ * @return 閫変腑瑙掕壊ID鍒楄〃 */ @Override - public List<Integer> selectRoleListByUserId(Long userId) { + public List<Long> selectRoleListByUserId(Long userId) { return baseMapper.selectRoleListByUserId(userId); } @@ -142,10 +139,11 @@ */ @Override public String checkRoleNameUnique(SysRole role) { - Long roleId = Validator.isNull(role.getRoleId()) ? -1L : role.getRoleId(); - SysRole info = getOne(new LambdaQueryWrapper<SysRole>() - .eq(SysRole::getRoleName, role.getRoleName()).last("limit 1")); - if (Validator.isNotNull(info) && info.getRoleId().longValue() != roleId.longValue()) { + Long roleId = StringUtils.isNull(role.getRoleId()) ? -1L : role.getRoleId(); + long count = count(new LambdaQueryWrapper<SysRole>() + .eq(SysRole::getRoleName, role.getRoleName()) + .ne(SysRole::getRoleId, roleId)); + if (count > 0) { return UserConstants.NOT_UNIQUE; } return UserConstants.UNIQUE; @@ -159,10 +157,11 @@ */ @Override public String checkRoleKeyUnique(SysRole role) { - Long roleId = Validator.isNull(role.getRoleId()) ? -1L : role.getRoleId(); - SysRole info = getOne(new LambdaQueryWrapper<SysRole>() - .eq(SysRole::getRoleKey, role.getRoleKey()).last("limit 1")); - if (Validator.isNotNull(info) && info.getRoleId().longValue() != roleId.longValue()) { + Long roleId = StringUtils.isNull(role.getRoleId()) ? -1L : role.getRoleId(); + long count = count(new LambdaQueryWrapper<SysRole>() + .eq(SysRole::getRoleKey, role.getRoleKey()) + .ne(SysRole::getRoleId, roleId)); + if (count > 0) { return UserConstants.NOT_UNIQUE; } return UserConstants.UNIQUE; @@ -175,8 +174,25 @@ */ @Override public void checkRoleAllowed(SysRole role) { - if (Validator.isNotNull(role.getRoleId()) && role.isAdmin()) { - throw new CustomException("涓嶅厑璁告搷浣滆秴绾х鐞嗗憳瑙掕壊"); + if (StringUtils.isNotNull(role.getRoleId()) && role.isAdmin()) { + throw new ServiceException("涓嶅厑璁告搷浣滆秴绾х鐞嗗憳瑙掕壊"); + } + } + + /** + * 鏍¢獙瑙掕壊鏄惁鏈夋暟鎹潈闄� + * + * @param roleId 瑙掕壊id + */ + @Override + public void checkRoleDataScope(Long roleId) { + if (!SysUser.isAdmin(SecurityUtils.getUserId())) { + SysRole role = new SysRole(); + role.setRoleId(roleId); + List<SysRole> roles = SpringUtils.getAopProxy(this).selectRoleList(role); + if (StringUtils.isEmpty(roles)) { + throw new ServiceException("娌℃湁鏉冮檺璁块棶瑙掕壊鏁版嵁锛�"); + } } } @@ -187,7 +203,7 @@ * @return 缁撴灉 */ @Override - public int countUserRoleByRoleId(Long roleId) { + public long countUserRoleByRoleId(Long roleId) { return userRoleMapper.selectCount(new LambdaQueryWrapper<SysUserRole>().eq(SysUserRole::getRoleId, roleId)); } @@ -198,7 +214,7 @@ * @return 缁撴灉 */ @Override - @Transactional + @Transactional(rollbackFor = Exception.class) public int insertRole(SysRole role) { // 鏂板瑙掕壊淇℃伅 baseMapper.insert(role); @@ -212,7 +228,7 @@ * @return 缁撴灉 */ @Override - @Transactional + @Transactional(rollbackFor = Exception.class) public int updateRole(SysRole role) { // 淇敼瑙掕壊淇℃伅 baseMapper.updateById(role); @@ -239,7 +255,7 @@ * @return 缁撴灉 */ @Override - @Transactional + @Transactional(rollbackFor = Exception.class) public int authDataScope(SysRole role) { // 淇敼瑙掕壊淇℃伅 baseMapper.updateById(role); @@ -265,7 +281,7 @@ list.add(rm); } if (list.size() > 0) { - rows = roleMenuMapper.insertAll(list); + rows = roleMenuMapper.insertAll(list); } return rows; } @@ -286,7 +302,7 @@ list.add(rd); } if (list.size() > 0) { - rows = roleDeptMapper.insertAll(list); + rows = roleDeptMapper.insertAll(list); } return rows; } @@ -298,7 +314,7 @@ * @return 缁撴灉 */ @Override - @Transactional + @Transactional(rollbackFor = Exception.class) public int deleteRoleById(Long roleId) { // 鍒犻櫎瑙掕壊涓庤彍鍗曞叧鑱� roleMenuMapper.delete(new LambdaQueryWrapper<SysRoleMenu>().eq(SysRoleMenu::getRoleId, roleId)); @@ -314,13 +330,13 @@ * @return 缁撴灉 */ @Override - @Transactional + @Transactional(rollbackFor = Exception.class) public int deleteRoleByIds(Long[] roleIds) { for (Long roleId : roleIds) { checkRoleAllowed(new SysRole(roleId)); SysRole role = selectRoleById(roleId); if (countUserRoleByRoleId(roleId) > 0) { - throw new CustomException(String.format("%1$s宸插垎閰�,涓嶈兘鍒犻櫎", role.getRoleName())); + throw new ServiceException(String.format("%1$s宸插垎閰�,涓嶈兘鍒犻櫎", role.getRoleName())); } } List<Long> ids = Arrays.asList(roleIds); @@ -338,43 +354,47 @@ * @return 缁撴灉 */ @Override - public int deleteAuthUser(SysUserRole userRole) - { - return userRoleMapper.deleteUserRoleInfo(userRole); + public int deleteAuthUser(SysUserRole userRole) { + return userRoleMapper.delete(new LambdaQueryWrapper<SysUserRole>() + .eq(SysUserRole::getRoleId, userRole.getRoleId()) + .eq(SysUserRole::getUserId, userRole.getUserId())); } /** * 鎵归噺鍙栨秷鎺堟潈鐢ㄦ埛瑙掕壊 * - * @param roleId 瑙掕壊ID + * @param roleId 瑙掕壊ID * @param userIds 闇�瑕佸彇娑堟巿鏉冪殑鐢ㄦ埛鏁版嵁ID * @return 缁撴灉 */ @Override - public int deleteAuthUsers(Long roleId, Long[] userIds) - { - return userRoleMapper.deleteUserRoleInfos(roleId, userIds); + public int deleteAuthUsers(Long roleId, Long[] userIds) { + return userRoleMapper.delete(new LambdaQueryWrapper<SysUserRole>() + .eq(SysUserRole::getRoleId, roleId) + .in(SysUserRole::getUserId, Arrays.asList(userIds))); } /** * 鎵归噺閫夋嫨鎺堟潈鐢ㄦ埛瑙掕壊 * - * @param roleId 瑙掕壊ID + * @param roleId 瑙掕壊ID * @param userIds 闇�瑕佸垹闄ょ殑鐢ㄦ埛鏁版嵁ID * @return 缁撴灉 */ @Override - public int insertAuthUsers(Long roleId, Long[] userIds) - { + public int insertAuthUsers(Long roleId, Long[] userIds) { // 鏂板鐢ㄦ埛涓庤鑹茬鐞� + int rows = 1; List<SysUserRole> list = new ArrayList<SysUserRole>(); - for (Long userId : userIds) - { + for (Long userId : userIds) { SysUserRole ur = new SysUserRole(); ur.setUserId(userId); ur.setRoleId(roleId); list.add(ur); } - return userRoleMapper.batchUserRole(list); + if (list.size() > 0) { + rows = userRoleMapper.insertAll(list); + } + return rows; } } -- Gitblit v1.9.3