From d52ece745ebe19f97d24d807d64e9a7a601b77ce Mon Sep 17 00:00:00 2001 From: KonBAI <1527468660@qq.com> Date: 星期六, 22 一月 2022 15:00:58 +0800 Subject: [PATCH] !132 优化查询是否存在的方法,替换魔法值为已定义的常量 * fix 替换查询所有子部门数中魔法值为已定义的常量 * fix 1.修改查询是否存在的方法改为baseMapper.exists()方法查询。 2.将部分魔法值改为已定义的常量 --- ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysDataScopeServiceImpl.java | 13 ++++++------- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysDataScopeServiceImpl.java b/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysDataScopeServiceImpl.java index 8439958..2803a59 100644 --- a/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysDataScopeServiceImpl.java +++ b/ruoyi-system/src/main/java/com/ruoyi/system/service/impl/SysDataScopeServiceImpl.java @@ -7,20 +7,19 @@ import com.ruoyi.system.domain.SysRoleDept; import com.ruoyi.system.mapper.SysDeptMapper; import com.ruoyi.system.mapper.SysRoleDeptMapper; -import com.ruoyi.system.service.SysDataScopeService; -import org.springframework.beans.factory.annotation.Autowired; +import com.ruoyi.system.service.ISysDataScopeService; +import lombok.RequiredArgsConstructor; import org.springframework.stereotype.Service; import java.util.List; import java.util.stream.Collectors; +@RequiredArgsConstructor @Service("sdss") -public class SysDataScopeServiceImpl implements SysDataScopeService { +public class SysDataScopeServiceImpl implements ISysDataScopeService { - @Autowired - private SysRoleDeptMapper roleDeptMapper; - @Autowired - private SysDeptMapper deptMapper; + private final SysRoleDeptMapper roleDeptMapper; + private final SysDeptMapper deptMapper; @Override public String getRoleCustom(Long roleId) { -- Gitblit v1.9.3